You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I added that when the CI failed and a checkbox to the description here.
Do you look for cmake_minimum_required in test/CMakeLists.txt? If so, maybe that should be added to PFR's test/CML, instead of conditioning the tests.
Not yet. Usually cmake_minimum_required should be done at the top-level CML anyway.
As for PFR: only a subset of the tests require C++20. In B2 those won't be build in C++17 mode or below. So that change mirrors that, building as much as possible. I don't see a need to error out when building the tests with an older CMake version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those PRs have been merged:
So the exceptions can be removed.